[Freeciv-Dev] Re: (PR#4559) citymap iterators are misnamed

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Jul 13, 2003 at 09:04:42PM -0700, rwetmore@xxxxxxxxxxxx wrote:
> city coordinates:  2 args - city pos variables + no map checking
>    city_array_iterate        - iterates in gui/array order (for tiling)
>    city_iterate              - iterates in an outwards spiral or circle
>    city_iterate1             - iterates in an outwards spiral or circle
>                                excluding the center
> city+map coordinates: 6 args - map origin + map pos + city pos variables
>    city_checked_iterate      - iterates in city and map checked "pos"
>    city_checked_iterate1     - iterates in city and map checked "pos"
>                                excluding the center
> 
> This would match the form in the recent iterator cleanup patch in Dec
> with the "_map" confusion removed. We don't have map_map_iterators, so
> probably shouldn't have city_map_iterators.

no we need the distinction. city_iterate sounds too much like
cities_iterate, You need to know that you're iterating over the city _map_.

-mike