[Freeciv-Dev] Re: (PR#4449) revolution choice doesn't work

["ChrisK@xxxxxxxx" <ChrisK@xxxxxxxx>]

On Fri, Jul 11, 2003 at 12:37:07PM -0700, Jason Short wrote:
> --On Friday, July 11, 2003 12:32:50 -0700 "ChrisK@xxxxxxxx" 
> <ChrisK@xxxxxxxx> wrote:
> 
> > On Thu, Jul 10, 2003 at 10:40:35AM -0700, Jason Short wrote:
> >>
> >> [jshort@xxxxxxxxxxxxxx - Fri Jun 27 18:41:01 2003]:
> >>
> >> > I selected menu kingdom->government->democracy.
> >> >
> >> > Several turns later, my revolution is over.  Up pops the "choose your
> >> > government" dialog.  Most confusing of all, the "revolution finished"
> >> > message comes up about a dozen times.
> >>
> >> When the revolution is over, the server sends a player packet to the
> >> player.  This packet includes packet->revolution==0 to tell that the
> >> revolution is over.  The client sees that revolution==0 while the
> >> government is still anarchy and does the "end revolution" handling.
> >
> > It shouldn't do anything here, if the user has ordered "Democracy" before.
> > Or better the packet wasn't sent.
> 
> I'm not sure what you mean by "shouldn't".  The problem is: how do we tell 
> if this packet is a new revolution-ended packet, or a duplicate one?  We 
> could do it with the introduction of a new static variable, but this just 
> gives more possibility for bugs (on disconnect, re-revolution, etc.).

As I understand it, there are 2 packets, one for revolution ended and one
for new government. The first one is for the popup dialog to appear. If the
player already determined democracy as new government at the time he has
started Revolution, just tell the client the new government. Or does the
"revolution ended" packet have more functionality than just popup the Gov.
dialog?

Another point. It should be possible for the player to change her mind
whenever she wants to, as long as the revolution continues. If she started
with "Democracy", she should be able to say "Republic" one turn later, or
just "Revolution", to get the popup later on. And vice versa.

A message should be printed which informs about the upcoming government
form, or just "Revolution" if none is determined, each time she issues such
a command. This is an important decision in the game and should have clear
feedback.

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.