[Freeciv-Dev] (PR#4479)

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

In handle_unit_info() in client/packhand.c, when a unit changes location
if it moves out of sight it is deleted and the function immediately
returns.  Just below this we check to see if the unit is leaving a city,
and update that city's occupied flag if so.

Thus if a unit moves out of a city and off into the unknown the city's
occupied information will not be updated.  I believe the attached patch
will fix it.  This just moves the unit removal down below the city check.

I remember there being several bugs reported that could be caused by
this, but I don't know where they are offhand.  Any testing would be good.

jason

city_occupied.diff
Description: city_occupied.diff