[Freeciv-Dev] Re: (PR#4225) mingw32 & libiconv problem

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Per I. Mathisen wrote:
> I undefined HAVE_ICONV, and now I can compile the win32 client, but I get
> this:

The other (probably better) way to look at this bug: configure is 
detecting iconv to be present, even though it isn't.  It's the same as 
the ESD bug in mingw32 - it detects the linux installation not the 
mingw32 one.

There's not much to do about this except get a new iconv.m4.  There may 
be a more up-to-date one, or the bug may still be unfixed in 
(GNU/glibc?) iconv (in which case we we should probably fix it).

> 1: You are running Freeciv without using iconv.  Unless
> you are using the latin1 character set, some characters
> may not be displayed properly.  You can download iconv
> at http://gnu.org/.
> 1: last message repeated 2 times
> 1: last message repeated 2 times (total 4 repeats)
> 1: last message repeated 4 times (total 8 repeats)
> 1: last message repeated 8 times (total 16 repeats)
> 1: last message repeated 16 times (total 32 repeats)
> 1: last message repeated 32 times (total 64 repeats)
> 1: last message repeated 64 times (total 128 repeats)
> 1: last message repeated 128 times (total 256 repeats)
> 1: last message repeated 256 times (total 512 repeats)
> 1: last message repeated 512 times (total 1024 repeats)
> 1: last message repeated 1024 times (total 2048 repeats)
> 1: last message repeated 2048 times (total 4096 repeats)
> 
> Do we really have to say that so many times? I think I got it the first
> time ;)

Just add a static variable to the appropriate function, I believe in 
common/shared.c.  I didn't do it before since it didn't seem like a big 
deal (it's not like it gets printed out all 4096 times :-).

jason