[Freeciv-Dev] Re: (PR#4200) two bugfixes to intelligence

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Sun, May 11, 2003 at 06:14:45AM -0700, Per I. Mathisen wrote:
> 
> On Sun, 11 May 2003, Raimar Falke wrote:
> > > The first sends A_NONE instead of A_UNSET for the tech a player is
> > > researching if the intelligencing player does not know what it is. This
> > > way the clients will not core if they try to display this information
> > > (none do at present though).
> >
> > IMHO A_LAST is the better choice here. In both cases (A_LAST and
> > current A_UNSET) you have to add a check to the client. IMHO you
> > should change the client to not core and let A_UNSET stay.
> 
> A_UNSET should only be used for things that can actually be unset, ie for
> tech goals. Setting pplayer->research.researching to A_UNSET is a bug, it
> is never done elsewhere, as far as I can see.

Ok.

> What should the client display for A_UNSET? This value is unset, you would
> have to special case it, which is unnecessary when A_NONE is a valid tech
> with a description that the client can display and which makes perfect
> sense.

from common/tech.h:

   A_NONE is the root tech. All players always know this tech. It is
   used as a flag in various cases where there is no tech-requirement.

This would mix things again. We seperated A_* usage some months ago.

So I change my opinion to: I'm for A_LAST or a new A_NOINFO (or
similar).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The Internet is really just a series of bottlenecks 
  joined by high speed networks."
    -- Sam Wilson