[Freeciv-Dev] Re: (PR#4200) two bugfixes to intelligence

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Sun, 11 May 2003, Raimar Falke wrote:
> > The first sends A_NONE instead of A_UNSET for the tech a player is
> > researching if the intelligencing player does not know what it is. This
> > way the clients will not core if they try to display this information
> > (none do at present though).
>
> IMHO A_LAST is the better choice here. In both cases (A_LAST and
> current A_UNSET) you have to add a check to the client. IMHO you
> should change the client to not core and let A_UNSET stay.

A_UNSET should only be used for things that can actually be unset, ie for
tech goals. Setting pplayer->research.researching to A_UNSET is a bug, it
is never done elsewhere, as far as I can see.

What should the client display for A_UNSET? This value is unset, you would
have to special case it, which is unnecessary when A_NONE is a valid tech
with a description that the client can display and which makes perfect
sense.

  - Per