Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2003:
[Freeciv-Dev] Re: (PR#4184) Pre-commit code
Home

[Freeciv-Dev] Re: (PR#4184) Pre-commit code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: bursig@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#4184) Pre-commit code
From: "Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>
Date: Wed, 7 May 2003 06:46:33 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Wed, May 07, 2003 at 03:51:07AM -0700, Rafa³ Bursig wrote:
> 
> Hi
> 
> I'm going to commit my home tree to main cvs but before that I need 
> this code in main cvs.
> If someone hasve something agains this code then ... "Speak now or be 
> silent forever".

There are style issues.

Why do you have to move the send_player_info and global_city_refresh
around?

It looks like nobody looks at the transmitted data at the client side.

What is the reason for the changes in client/packhand.c?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "This is Linux Country. On a quiet night, you can hear Windows reboot."




[Prev in Thread] Current Thread [Next in Thread]