Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2003:
[Freeciv-Dev] Re: (PR#4184) Pre-commit code 		Home

[Freeciv-Dev] Re: (PR#4184) Pre-commit code

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: bursig@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#4184) Pre-commit code
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Wed, 7 May 2003 07:45:23 -0700
Reply-to: rt@xxxxxxxxxxxxxx 
On Wed, 7 May 2003, Rafa³ Bursig wrote:
> I'm going to commit my home tree to main cvs but before that I need
> this code in main cvs.
> If someone hasve something agains this code then ... "Speak now or be
> silent forever".

Nitpick:

You don't need these checks:

   +  if (has_capability("citizens_style", pc->capability)) {

when you make citizens_style a mandatory capability.

  - Per
[Prev in Thread] Current Thread [Next in Thread]