[Freeciv-Dev] Re: (PR#3936) introducing native coordinates

[Ross Wetmore <rwetmore@xxxxxxxxxxxx>]

Note, odd iso map coordinates are quite valid for maps that do not wrap
in that dimension. The condition to be checked is that wrap coordinate
dimensions must be even.

In the odd case, the code should be careful to insure that it allocates
all dimensions to the next higher even boundary. This insures that all
native iterators always run over the same number of grid points whether
or not it is an even or odd line. The extra points will never be used
or allowed in map operations though.

This is pretty much done by default without any special handling, but
should be verified.

Cheers,
RossW
=====

Raimar Falke wrote:
> On Thu, Apr 24, 2003 at 08:58:16AM -0500, Jason Dorje Short wrote:
[...]
> > On a related note, if you specify an odd ysize in an iso-map that wraps 
> > in the y direction, you will get very odd behavior.  You have to have an 
> > even dimension to wrap in a particular direction.  Your variant1 (the 
> > same as gen-topology uses) enforces this by compressing in the x 
> > direction; your variant2 compresses in the y.  But neither accounts for 
> > the other direction.
>
> Ahh yes that is another point which I think your gen_topo patch is
> bad. It should not accept certain wrappings or sizes or should correct
> the size by adding one.
[...]
>         Raimar