[Freeciv-Dev] Re: (PR#3736) Pregame player list

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Apr 21, 2003 at 01:58:51PM -0700, andrearo@xxxxxxxxxxxx wrote:
> >these inits near the top of civclient.c,
> >
> The reason I used those functions was that the conn_lists are not 
> cleared when a client connects to a server in pregame, then disconnects 
> and connects to the same server in pregame state. However, I think 
> client_remove_all_cli_conn() can be used there instead. Right?

yes. you get lucky that the list unlink is an implicit init, but this
should not be in the gui code. It should probably should be at the bottom
of clinet.c:close_socket_nomessage(), though vasc should verify this.

it seems that if we're in pregame and disconnect, client_game_free()
doesn't get called. hmm. interesting.
 
> Is there anything else that could be changed?  It would be nice to have 
> a teamname column as well..

hmm, better to have a right click or tooltip or something on the row to 
bring up extra info, since we want the dialog to be unobstrusive.

update_conn_list_model() should be renamed update_conn_list_dialog() as
model is very gtk2-centric.

other than these, the ball is in vasc's court. I would very much like to
see gtk1.2 and xaw versions of this when committed too.

-mike