[Freeciv-Dev] Re: (PR#3736) Pregame player list

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Apr 19, 2003 at 11:59:53AM -0700, andrearo@xxxxxxxxxxxx wrote:
> Vasco Alexandre da Silva Costa wrote:
> 
> >[andrearo@xxxxxxxxxxxx - Sun Mar 16 10:18:19 2003]:
> >
> >I like it. I want some more IRC like features for the chat part.
> >Nothing too fancy for now. Easy things first.
> >
> >But:
> >* lose the icons. they are providing no info. they only confuse.
> >* remove the TreeView header and use a label with a mnemonic for the list
> >  instead (checkout the find dialog for this).
> >
> Sure, now I've made the list text-only and added a label instead.
> 
> To make sure that game.est_connections always contains
> a correct list of connections, I had to change connecthand.c:
>  -  struct conn_list *dest = &pconn->self;
> +  struct conn_list *dest = &game.est_connections;
> It solves the problem, but is this the correct way to do it?

no it isn't. To see why, connect a first client to the server and then
connect a second. watch what happens.

-mike