[Freeciv-Dev] Re: [FreeCiv-Cvs] glip: Fixing some bugs in the PF, namely * ZoC shoul...

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Sat, 19 Apr 2003 freeciv@xxxxxxxxxxxxxxxxxxx wrote:

> This is an automated notification of a change to freeciv cvs, 
> on Sat Apr 19 10:55:37 PDT 2003 = Sat Apr 19 17:55:37 2003 (GMT)
> by Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
> 
> ---- Files affected:
> 
> freeciv/common/aicore path_finding.c
> 
> ---- Log message:
>       Tag: HEAD
> 
> Fixing some bugs in the PF, namely
> * ZoC should not prevent us from attacking an enemy
> * we shouldn't attempt to go back further than the initial point of a path
> * if a path to a dangerous tile is requested, return NULL instead of
> crashing
> * undefined paths should detected (instead segfaulting) when printing (RF)
> * print direction when printing paths (RF)

The last change causes trouble.  I am sorry I didn't check it properly...
It attempts to print the direction from the last tile on the path, which 
is of course not defined (set to -1).  Which triggers an assert in 
dir_get_name.  Actually, I would rather remove the assert and return "--" 
instead of the direction name.  Let me know your opinions.

(The code in CVS is actually not broken as such as nobody uses 
print_path).

G.