[Freeciv-Dev] Re: (PR#3424) New flush code

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Tue, Mar 04, 2003 at 07:26:30PM -0800, Jason Short wrote:
> Raimar Falke wrote:
> > On Sun, Mar 02, 2003 at 11:49:05PM -0800, Jason Short wrote:
> 
> >>+static void queue_flush(void)
> >>+{
> >>+  if (!is_flush_queued) {
> >>+    if (SDL_PushEvent(&flush_user_event) == 0) {
> >>+      is_flush_queued = TRUE;
> >>+    }
> > 
> > 
> >>+    /* Else nothing... */
> > 
> > 
> > Here have lost a flush call. Bad.
> 
> This should be sufficiently rare that it's not *that* bad.  I don't 
> really see a way around it.

We can at least write "You stomped about an SDL limitation please
report to freeciv-dev@..." This way we can get an grip how common this
is.

> > Some comments in gui-sdl refer to GTK. This is odd.
> 
> Oops, fixed.
> 
> > Also I would like some more formal description of this. What is
> > flushed to which destination? Also you speak about screen. This is
> > IMHO wrong. It should be (visible) map canvas.
> 
> Hmm, I thought about this.  The current function names don't really say 
> much about *what* is being flushed, although since it's in mapview.c I 
> guess it is implied that we're talking about the mapview here.  It might 
> make sense to support this for other canvases (e.g., the overview canvas).
> 
> I guess I'm not sure what additional description should be written, and 
> where.

What about a new doc/README.mapview? It will talk about the layers,
where animation, grid and goto lines are drawn, what buffers exists
and so on. I think that you have already written this. You can recycle
one of your mails for this.

        Raimar
-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I do feel kind of sorry for Microsoft. Their attornies and marketing
  force must have tons of ulcers trying to figure out how to beat (not
  just co-exist with) a product that has no clearly defined (read
  suable) human owner, and that changes on an hourly basis like the
  sea changes the layout of the sand on a beach. Severely tough to
  fight something like that."
    -- David D.W. Downey at linux-kernel