[Freeciv-Dev] Re: (PR#3602) no_contact cleanup

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Mon, 3 Mar 2003, Per I. Mathisen wrote:

> 
> This is a small cleanup of no_contact handling in the paradrop code. After
> the cleanup, the pplayer_no_contact function is no longer needed, and is
> removed.
> 
> I will commit later unless someone screams.

Scre-e-e-a-a-am!

Your patch is wrong: what if there are two units from different players on 
the tile?  What if there are other players units in the city?

You should use maybe_make_first_contact instead which handles all things 
properly.

G.