[Freeciv-Dev] Re: (PR#3424) New flush code

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Wed, Feb 26, 2003 at 12:06:13AM -0800, Jason Short wrote:
> > I think you brought this up and I now think it is a good idea: calling
> > gui_callback_finished after each event. For this we have to break up
> > the main loop. This is possible for:
> >  - xaw: http://www.xfree86.org/4.2.0/XtAppNextEvent.3.html
> >  - gtk: 
> > http://developer.gnome.org/doc/API/gtk/gtk-general.html#GTK-MAIN-ITERATION
> >  - gtk2: 
> > http://developer.gnome.org/doc/API/2.0/gtk/gtk-General.html#gtk-main-iteration
> > 
> > sdl, win32 and mui already have to loop broken up in the current
> > source code.
> 
> I don't understand what you're saying.  You want to break up the GUI's 
> main event loop, replacing gtk_main() with something like
> 
>    while (!done) {
>      gtk_main_iteration();
>      flush_dirty();
>    }
> 
> ?

Yes.

> What if flush_dirty() itself generates a new GTK/GDK event?

As it should do this only once this isn't a problem.

> This is again hideously expensive

Why is it expensive? You call flush_dirty, see that num_dirty_rects is
0 and return.

> and quite error-prone.

Why? I don't think so. I think it is the cleanest solution and the one
with the fewest possible errors.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "SIGDANGER - The System is likely to crash soon"