[Freeciv-Dev] Re: (PR#3456) eXplore broken

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Quoting Cameron Morland <cameron@xxxxxxxxxx>:

> On Tue, Feb 18, 2003 at 04:19:20AM -0800, ChrisK@xxxxxxxx wrote:
> > Please try attached savegame.
> 
> Right.
> 
> The WARMAP_SEACOST seems to like to return 255, so when we check
> is_dist_finite, which evaluates to `255 < 255` or FALSE, we abandon
> the tile. It ceases to be a problem if the !is_dist_finite line is
> removed from ai_manage_explorer. 
> 
> The problem seems to be that for tiles which actually are far away,
> the warmap cost is 255, so we consider it too far away. I don't think
> this is good, I think we should remove the is_dist_finite check. That
> function, incidentally, appears to be used nowhere else but in this
> explorer code.

Right.  Because I put it there.  And it should stay there too.  The problem is
in warmap generation which uses ad hoc thresholds.  And if you remove
is_dist_finite, the manage_explorer will be made to believe that distance is 255
when it is not.

The only solution is to fix warmap.  This is right now in heavy development, so
please wait.

G.