[Freeciv-Dev] Re: (PR#3456) eXplore broken

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Quoting Cameron Morland <cameron@xxxxxxxxxx>:

> On Tue, Feb 18, 2003 at 04:19:20AM -0800, ChrisK@xxxxxxxx wrote:
> > On Mon, Feb 17, 2003 at 05:25:06PM -0800, Cameron Morland wrote:
> > > On Mon, Feb 17, 2003 at 09:21:56AM -0800, ChrisK@xxxxxxxx wrote:
> > > > 
> > > > CVS 17 FEB 2003 Gtk+ 1.2
> > > > 
> > > > Explore mode for ships isn't entered, even when half
> > > > of map is undiscovered. Neither X nor menue work.
> > > > 
> > > > Savegame available.
> > > 
> > > I can't reproduce this using the gui-gtk client. I'm hoping it's a GUI
> > > bug, and not my fault. :)
> > 
> > Please try attached savegame.
> 
> Right.
> 
> The WARMAP_SEACOST seems to like to return 255, so when we check
> is_dist_finite, which evaluates to `255 < 255` or FALSE, we abandon
> the tile. It ceases to be a problem if the !is_dist_finite line is
> removed from ai_manage_explorer. 
> 
> The problem seems to be that for tiles which actually are far away,
> the warmap cost is 255, so we consider it too far away. I don't think
> this is good, I think we should remove the is_dist_finite check. That
> function, incidentally, appears to be used nowhere else but in this
> explorer code.
> 
> 
>