[Freeciv-Dev] Re: (PR#2748) mapgen patch 1 of 3 - adjust_terrain()

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Tue, 28 Jan 2003, Karen Yeats via RT wrote:

> Hello anyone who might be following this.

Mmmh, yeah, hi :)

> Ross Wetmore and I have been conversing on this patch a bit and in
> particular have been disagreeing about whether my way of turning the
> river server variable to percents is the way to go.  

I would say just break the compatibility.  This is what you are doing 
right?

> Does anyone else care? Or shall we just disagree to our hearts' content.

Doesn't seem so.  I will write a separate email on this issue.

Now, I would like you to fix the style issues and then we can commit the 
patch, ok?

Style issues are:
+  if(total != 100 - polar){
should be
+  if (total != 100 - polar) {

+  if (terrain_control.river_style == R_AS_TERRAIN)
+    total += map.riverlength;
should be
+  if (terrain_control.river_style == R_AS_TERRAIN) {
+    total += map.riverlength;
+  }

and could you convert the number below to decimal for us peasants, please?

-       settings and as many rivers as possible with 'set rivers 1000'. */
+       settings and as many rivers as possible with 'set rivers 100'. */
     0xD000;
 
Best wishes,
G.