[Freeciv-Dev] Re: (PR#2789) Units sometimes remain displayed in fog of war

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Quoting Jason Short via RT <rt@xxxxxxxxxxxxxx>:

> 
> [guest - Fri Jan 10 05:26:04 2003]:
> 
> > Sometimes, enemy units remain displayed in the fog of war. This is
> > usually after a unit has attacked, or a ship has unloaded during the
> > enemy move turn.  For instance, if an enemy ship is in the fog of war,
> > but unloads a unit within my view range, the enemy ship remains visible.
> >  If I move away from the enemy ship in my turn, it remains displayed in
> > the fog of war square.
> > 
> > I'm using CVS from Jan 5, gtk2 client on RH8.  A savegame is available
> > at http://kenn-michelle.ca:8080/freeciv/fog.sav.gz (should I attach
> > savegames to here?.. they can be big).  Join as kenn.  Note area around
> > Ottawa.  End turn.  Note the enemy ship next to Ottawa.  Move destroyer
> > away from that area.  Wait a turn.  Move destroyer back to that area. 
> > The enemy ship is still displayed, and you can even move on top of it,
> > although it isn't actually there.
> 
> This is not a drawing bug.  It appears that the core client code
> actually thinks that there's a ship at that location.  Very bizarre!

Yeah, I see this bug from time to time.

I suspect it's another bug caused by:
================================================================
This is an automated notification of a change to freeciv cvs, 
on Sat Jun  1 12:25:26 PDT 2002 = Sat Jun  1 19:25:26 2002 (GMT)
by Per I. Mathisen <per@xxxxxxxxxxx>

---- Files affected:

freeciv/common player.c unit.c
freeciv/server unittools.c

---- Log message:

Ensure that client does not have information about invisible enemy units.
This closes a potential for cheating.

Patch by Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
================================================================

The loophole was _very_ hard to close, so we might see more of such bugs.

Hopefully I can hunt it down, with the savegame Kenn provided.

Thanks,
G.