[Freeciv-Dev] (PR#2327) Preselecting government

["Arnstein Lindgard via RT" <rt@xxxxxxxxxxxxxx>]

I have a suggestion patch for this ticket. Applies to GTK1, with two
mostly empty inserted functions in the other clients to maintain
compatibility.

You can preselect gov't from radio buttons at revolt time.

There is a magic number: menu space for 6 gov'ts to allow for
Fundamentalism or modpacks. I don't know if you can have a variable number
of radio buttons. Unused slots are blanked out and made insensitive.
At game start the name of the gov't rado buttons are defined.

Introduced client/automation.ch. I thought that would be a good place
to hold simple auto-stuff unlike intelligent agents. I also have a patch
for preselecting diplomat actions that could go here if it is desired.


Examples of output:
  (popup) "Revolution!" - "Change to Republic?" (yes/no)

If you change radio button during anarchy, still no more popups occur:
  "Game: The Romans are planning to form a Monarchy!"

And if you don't have that tech, while in anarchy:
  "Game: Warning! You don't have the required technology for Monarchy!"

Then a popup will occur unless you change it, or gain the tech while in
anarchy.

If you preselect a gov't before you actually have the technology, still
no popups:
  "Game: The Romans demand Democracy!"
  "Game: Revolution will start when the required technology is available!"

When the tech is gained:
  "Game: The Romans demand Democracy immediately!"
  (auto-revolt)

If you change it back to current gov't before revolution:
  "Game: The Revolution has been cancelled! The Romans are happy with Republic!"


The old way of revolting still works as before.
This is a client-side player aid.
I wonder, do y'all think this is a good way of doing things?

Patch vs. cvs Feb 09.


Arnstein

revolt.diff.gz
Description: revolt.diff.gz