[Freeciv-Dev] Re: (PR#2486) Civ 2 Style Waste

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Jason Short via RT <rt@xxxxxxxxxxxxxx> wrote:
> 
> [raahul_da_man@xxxxxxxxx - Thu Jan  2 11:48:00 2003]:
> 
> > This is the waste patch updated to 2nd January CVS, with all new waste
> > mandatory capability. No longer can old clients connect. This is due
> > to the waste implementation breaking backwards compatibility with old
> > clients/servers.
> > 
> > It is otherwise identical to the previous waste patches.
> > 
> > Aloha,
> > RK.

> * The +waste capability needs to have an explanation (like the other
> capabilities, right below the capstr).

OK.
 
> * It is not immediately intuitive that shield_prod is the post-waste
> production.  IMO this should be explained in city.h where it's declared.

This is similar to the existing trade_prod, but ok.
 
> * The line
> 
> +  /* TODO: Civ2 rules check */
> 
> means nothing to me.  Can this be explained better?  If it refers to the
> discussion on how waste is calculated in civ2, shouldn't this go into
> city_waste()?

I plan to remove this line with the next set of patches. I refer you to the
original discussion. It's not just waste. Corruption is also calculated
differently in Civ2. I'm going to change both waste and corruption in the next 
series. 

> * Can you give an explanation (in comment) of the "waste modifiers" in
> government.h?

I'll put in a comment "Look at default/governments.ruleset".
All the corruption and waste modifiers work exactly the same way.

> * If you're not going to change any rulesets other than default, you
> should use secfile_lookup_int_default instead of secfile_lookup_int to
> read the waste modifiers from the ruleset.  Otherwise trying to play
> under the civ2 ruleset is impossible.  Giving default values also allows
> backward-compatability with third-party rulesets.

OK. Just laziness on my part, as well as lack of data on Civ 2 Waste. I asked
Davide for help on this, but I guess it doesn't matter. It's very easy for
Davide to fix any wrong numbers I put in the Civ 2 ruleset.

> * Several trivial places have "bad" style.

Specifically? 

> We will also need more interface work, like support for other GUIs and
> cityrep support.  This could come after the core patch is applied, perhaps.

I haven't added Gui-gtk 2.0 because I don't have it installed at home. I
*refuse* to learn the abomination that is Xaw, and I can't get SDL and Win32 to
compile properly.  I don't think this is a showstopper. The client maintainers
can easily add support. Lack of support does not mean anything bad will happen,
just that players will wonder why their city does not produce enough shields.

How do I add cityrep report? 

> jason

Aloha,
RK.

Insanity -- a perfectly rational adjustment to an insane world. -R. D. Lang


__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com