[Freeciv-Dev] (PR#2486) Civ 2 Style Waste

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

[raahul_da_man@xxxxxxxxx - Thu Jan  2 11:48:00 2003]:

> This is the waste patch updated to 2nd January CVS, with all new waste
> mandatory capability. No longer can old clients connect. This is due
> to the
> waste implementation breaking backwards compatibility with old
> clients/servers.
> 
> It is otherwise identical to the previous waste patches.
> 
> Aloha,
> RK.
> 
> Ignorance is never out of style. It was in fashion yesterday, it is
> the rage
> today, and it will set the pace tomorrow. -Franklin K. Dane

* The +waste capability needs to have an explanation (like the other
capabilities, right below the capstr).

* It is not immediately intuitive that shield_prod is the post-waste
production.  IMO this should be explained in city.h where it's declared.

* The line

+  /* TODO: Civ2 rules check */

means nothing to me.  Can this be explained better?  If it refers to the
discussion on how waste is calculated in civ2, shouldn't this go into
city_waste()?

* Can you give an explanation (in comment) of the "waste modifiers" in
government.h?

* If you're not going to change any rulesets other than default, you
should use secfile_lookup_int_default instead of secfile_lookup_int to
read the waste modifiers from the ruleset.  Otherwise trying to play
under the civ2 ruleset is impossible.  Giving default values also allows
backward-compatability with third-party rulesets.

* Several trivial places have "bad" style.

We will also need more interface work, like support for other GUIs and
cityrep support.  This could come after the core patch is applied, perhaps.

jason