Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] Re: A minor style issue.
Home

[Freeciv-Dev] Re: A minor style issue.

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Cc: Freeciv Development List <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: A minor style issue.
From: Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 19 Dec 2002 09:24:46 -0600

On Thu, Dec 19, 2002 at 02:40:48PM +0000, Gregory Berkolaiko wrote:
> Our coding style guideline gives conflicting signal wrt use of
> spaces between "if" and the condition:
> 
> if(ptr == NULL)
> 
> vs.
> 
> if (ptr == NULL)
> 
> There are a couple of relevant bits of CodingStyle:
> 
> ==========
>     - spaces are inserted before and after operators ("int i, j, k;"
>       instead of "int a,b,c;" and "if (foo <= bar) c = a + b;" instead
>       of "if(foo<=bar) c=a+b;")
> ==========
> 
> and
> 
> ==========
> - Comments in conditionals. If you need a comment to show program flow,
>   it should be below the if or else:
> 
>   if(is_barbarian(pplayer)) {
>     x++;
> ==========
> 
> Should we clearly inforce one or the other?

no.

-mike


[Prev in Thread] Current Thread [Next in Thread]