Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] A minor style issue.
Home

[Freeciv-Dev] A minor style issue.

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Freeciv Development List <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] A minor style issue.
From: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Thu, 19 Dec 2002 14:40:48 +0000 (GMT)

Our coding style guideline gives conflicting signal wrt use of
spaces between "if" and the condition:

if(ptr == NULL)

vs.

if (ptr == NULL)

There are a couple of relevant bits of CodingStyle:

==========
    - spaces are inserted before and after operators ("int i, j, k;"
      instead of "int a,b,c;" and "if (foo <= bar) c = a + b;" instead
      of "if(foo<=bar) c=a+b;")
==========

and

==========
- Comments in conditionals. If you need a comment to show program flow,
  it should be below the if or else:

  if(is_barbarian(pplayer)) {
    x++;
==========

Should we clearly inforce one or the other?

G.




[Prev in Thread] Current Thread [Next in Thread]