[Freeciv-Dev] Re: A minor style issue.

[Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

On Thu, 2002-12-19 at 09:40, Gregory Berkolaiko wrote:
> Our coding style guideline gives conflicting signal wrt use of
> spaces between "if" and the condition:
> 
> if(ptr == NULL)
> 
> vs.
> 
> if (ptr == NULL)
> 
> There are a couple of relevant bits of CodingStyle:
> 
> ==========
>     - spaces are inserted before and after operators ("int i, j, k;"
>       instead of "int a,b,c;" and "if (foo <= bar) c = a + b;" instead
>       of "if(foo<=bar) c=a+b;")
> ==========
> 
> and
> 
> ==========
> - Comments in conditionals. If you need a comment to show program flow,
>   it should be below the if or else:
> 
>   if(is_barbarian(pplayer)) {
>     x++;
> ==========
> 
> Should we clearly inforce one or the other?

The "when in doubt, use indent -kr -..." part implies #2.  That's what I
always assumed was the standard (and I prefer it personally)...

jason