Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] Re: (PR#2476) myrand does the wrong thing
Home

[Freeciv-Dev] Re: (PR#2476) myrand does the wrong thing

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: cameron@xxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2476) myrand does the wrong thing
From: "Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>
Date: Wed, 4 Dec 2002 02:43:01 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Tue, Dec 03, 2002 at 03:29:16PM -0800, cameron@xxxxxxxxxx via RT wrote:
> On Tue, Dec 03, 2002 at 11:25:21AM -0800, Raimar Falke via RT wrote:
> > Problems: the call myrand(0) wouldn't change internal state. This is
> > bad. The attached patch fixes this by always going trough the
> > next-state step and has no early return. It also comment the function
> > a bit (now that I understood it).
> 
> Can you tell me why it's bad than myrand(0) doesn't change internal state?

It will make it non-reproducible/in-deterministic.

> It appears to work.

Good.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "> WHY?! Isn't it better to put $(shell cat cscope.files) on the list of
  I only have a yellow belt in makefile kungfu.  These fancy gnu make things
  are relatively new to some of us..."
    -- Mark Frazer to Vassilii Khachaturov in linux-kernel



[Prev in Thread] Current Thread [Next in Thread]