Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] Re: (PR#2476) myrand does the wrong thing
Home

[Freeciv-Dev] Re: (PR#2476) myrand does the wrong thing

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2476) myrand does the wrong thing
From: "cameron@xxxxxxxxxx via RT" <rt@xxxxxxxxxxxxxx>
Date: Tue, 3 Dec 2002 15:29:16 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Tue, Dec 03, 2002 at 11:25:21AM -0800, Raimar Falke via RT wrote:
> Problems: the call myrand(0) wouldn't change internal state. This is
> bad. The attached patch fixes this by always going trough the
> next-state step and has no early return. It also comment the function
> a bit (now that I understood it).

Can you tell me why it's bad than myrand(0) doesn't change internal state?

> Please test.

It appears to work.

-- 
+-----------------------------------------------------------------
| PGP http://www.eng.uwaterloo.ca/student/cjmorlan/public-key.pgp
| Cameron Morland             ----             Cameron@xxxxxxxxxx
|
| I cannot "mind my own business."
|     --Socrates
+-----------------------------------------------------------------

Attachment: pgplQjnrnQf1G.pgp
Description: PGP signature


[Prev in Thread] Current Thread [Next in Thread]