[Freeciv-Dev] 'bug' in mapgen.c (missing forests)

[Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

This is mainly for Ross or Karen or others who play around in mapgen.c:

There is a 'bug' in generator1 that manifests itself in civworld.
To see it, fire up civworld, generate a map (using the defaults) then
generate another map. If you take a look, there are no forests on the
entire map.

A cursory glance of mapgen.c reveals:

**************************************************************************/
static void make_island(int islemass, int starters,
                        struct gen234_state *pstate)
{
  static long int tilefactor, balance, lastplaced;/* int may be only 2 byte ! */
  static long int riverbuck, mountbuck, desertbuck, forestbuck, swampbuck;

which is ok for normal games (where you generate a map once) but not ok
for civworld.

Could someone confirm this diagnosis, and better yet get me a patch to fix
this issue?

-mike