[Freeciv-Dev] Re: [Patch] [RFC] Path finding version 14

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Mon, 16 Sep 2002, Raimar Falke wrote:

> On Sun, Sep 15, 2002 at 07:21:58PM +0100, Gregory Berkolaiko wrote:
> > 
> > And the last version of the patch.  First it makes one test run for all
> > units, both PF algorithms are used and if a difference in results is
> > detected, the whole thing aborts.  Then 100 runs of each algorithm for
> > each unit are done and the times are printed.
> > 
> > Usage: 
> > 1. Apply the patch to latest CVS.
> > 2. Load the attached game, connect, start and press Turn Done.
> > 3. Watch the output in the server screen.
> 
> Patch from x2 to x3 attached.

Cool

> 
> Problems:
> 
> 2: PF: path (at 0xbfffd440) is valid
> 2: PF:  consists of 4 positions:
> 2: PF:    0/ 4: (15,30) t/m= 0/ 3 dir=NW/ 6 BMC= 0 EC=0 COP=0
>                              ^^^^ this is known but it isn't required to fill 
> this out in TM_NONE mode
> 2: PF:    1/ 4: (14,29) t/m=-1/-1 dir=W / 9 BMC= 6 EC=291400 COP=291406
> 2: PF:    2/ 4: (13,29) t/m=-1/-1 dir=SW/ 3 BMC=15 EC=582700 COP=582715
> 2: PF:    3/ 4: (12,30) t/m=-1/-1 dir=--/-1 BMC=18 EC=883900 COP=883918
> 2: PF: path (at 0xbfffb7f0) is valid
> 2: PF:  consists of 4 positions:
> 2: PF:    0/ 4: (15,30) t/m=-1/-1 dir=NW/ 0 BMC= 0 EC=0 COP=0
>                                           ^ missing
> 2: PF:    1/ 4: (14,29) t/m=-1/-1 dir=W / 0 BMC= 6 EC=291400 COP=0
>                                                        same here ^
> 2: PF:    2/ 4: (13,29) t/m=-1/-1 dir=SW/ 0 BMC=15 EC=582700 COP=0
> 2: PF:    3/ 4: (12,30) t/m=-1/-1 dir=--/ 0 BMC=18 EC=883900 COP=0

I didn't do the things which I don't think should be there.  All 3 above 
discrepancies are of this sort.  IMO only BMC of the next step might ever 
be useful.

> 2: produced same output
> 2: compare_pf: create map for Gebirgsjфger at (62,24)
> 
> Gebirgsjфger = Alpine Troops
> 
> 2: PF: path (at 0xbfffd440) is valid
> 2: PF:  consists of 2 positions:
> 2: PF:    0/ 2: (62,24) t/m= 0/ 3 dir=NW/ 1 BMC= 0 EC=0 COP=0
> 2: PF:    1/ 2: (61,23) t/m=-1/-1 dir=--/-1 BMC= 1 EC=236100 COP=236101
>                                                  ^
> 2: PF: path (at 0xbfffb7f0) is valid
> 2: PF:  consists of 2 positions:
> 2: PF:    0/ 2: (62,24) t/m=-1/-1 dir=NW/ 0 BMC= 0 EC=0 COP=0
> 2: PF:    1/ 2: (61,23) t/m=-1/-1 dir=--/ 0 BMC= 3 EC=236100 COP=0
>                                                  ^
> 
> Your implementation also doesn't handle sea units.

It did, but then it was deleted by you :)
I'll put it in.  It never had support for F_IGTER though (see above).  But 
adding it shouldn't be a problem.

> You should use a larger test case. A random savegame which had CMA
> problems ;) attached. This should provide a good mix of unit types.

Savegame is missing :(
login as who?

G.