[Freeciv-Dev] Re: Caravans don't work anymore (PR#1551)

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Thu, Jun 13, 2002 at 12:39:25PM +0200, Christian Knoke wrote:
> On Wed, Jun 12, 2002 at 11:02:24PM +0200, Raimar Falke wrote:
> > 
> > Here is the patch. Changes:
> >  - various other changes: I remember the get_special_name one and
> >  removing some conditions which are useless and the size_t change.
> 
> Problems:
> 
> 1. In a running game, I managed to put the government dialog in the
> background, and continued playing. In the round after, there was a
> total of three government dialogs presented. I was able to do the
> choice three times, but only the first one was respected. It was
> possible to continue the game.

This is related to the "removing some conditions which are useless"
from above. The old code has a guard to prevent more than one
government dialog. This was removed and the attached readds it. The
old code also has guards to prevent multiple pillage or connect
dialogs (probably because of the static variable use). I removed the
static variables and it is now possible to have multiple pillage and
connect dialogs open (this is also possible with the current code but
will fail in odd ways).

> 2. While trying to reproduce (1.) (I have a savegame from just
>    before the government dialog is displayed), the dialog popped
>    up, and it was _not_ possible to ignore it. I have had to make
>    my choice.

Yes you can't ignore the government dialog. I would call it a
feature. The old code behave the same.

> 3. With (1.) as well as with (2.) I got the following civclient error:
> 
> Gtk-CRITICAL **: file gtkwidget.c: line 3310 (gtk_widget_set_sensitive):
> assertion idget != NULL' failed.
> 
> For (1.) I got it three times, for (2.) one time.

Can you try this with the patch?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 Make a software that is foolproof, and only fools will want to use it.

1551_fix1.diff
Description: Text document