Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2002:
[Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Remove superfluous assignment.
Home

[Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Remove superfluous assignment.

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Remove superfluous assignment. Reported by ...
From: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Date: Fri, 21 Jun 2002 16:50:00 +0200

On Fri, Jun 21, 2002 at 07:21:03AM -0700, freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> This is an automated notification of a change to freeciv cvs, 
> on Fri Jun 21 07:13:41 PDT 2002 = Fri Jun 21 14:13:41 2002 (GMT)
> by Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
> 
> ---- Files affected:
> 
> freeciv/client/gui-gtk dialogs.c
> 
> ---- Log message:
> 
> Remove superfluous assignment.

It should be noted that this whole usage of static variables is
fragile. If you reuqest two spy actions in parallel you will get
problems. Or if someone else is requesting them (an agent for
example). However you can't fix this in an easy way since you don't
get the spy id for an incoming cost packet.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  This message has been ROT-13 encrypted twice for extra security.


[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Remove superfluous assignment. Reported by ..., Raimar Falke <=