[Freeciv-Dev] Re: [Patch] Making city report list faster

[Reinier Post <rp@xxxxxxxxxx>]

On Mon, Jun 10, 2002 at 11:37:21AM +0200, Raimar Falke wrote:
> On Mon, Jun 10, 2002 at 11:17:21AM +0200, Raimar Falke wrote:
> > This is nonsense. What overhead do you want to avoid? TCP/IP overhead? 
> > Than insert connection_do_buffer/connection_do_unbuffer calls if you
> > know that you send multiple changes. sernet.c:sniff_packets does this
> > (this means that all response of a request are send back in one TCP/IP
> > packet). Also the CMA does this.
> 
> Attached patch does this. This isn't about latency but about TCP/IP
> overhead.

This is great!  I will try Change All with the beta client,
with and without your patch.

In server/sernet.c, you buffer and unbuffer for each individual
city change request packet, so the resulting info packets will still
be sent separately, if I understand correctly.  If this is true,
the connection_do_(un)buffer() calls can be pushed out of the
surrounding loop.

-- 
Reinier