[Freeciv-Dev] Re: Client continuously pops up connection dialogs (PR#1478)

[Kenn Munro <kenn@xxxxxxxxxxxxxx>]

Yes.. that patch fixes the client loop.  It exits peacefully with:

2: lost connection to server
civclient: cma_core.c:582: get_current_as_result: Assertion `worker +
result->entertainers + result->scientists + result->taxmen ==
pcity->size' failed.
Aborted

Thanks...

Kenn

On Mon, 2002-05-20 at 05:37, Jason Short wrote:
> kenn@xxxxxxxxxxxxxx wrote:
> > Full_Name: Kenn Munro
> > Version: 1.12.3-devel
> > Distribution: Built from source
> > Client: Gtk+
> > OS: Red Hat 7.2
> > Submission from: (NULL) (216.104.110.108)
> > 
> > 
> > The civclient sometimes continuously pops up connection dialog boxes after 
> > being
> > disconnected (i.e. from a civserver crash).  I mentioned this in my previous
> > PR#1477, but was unable to reproduce the error.  I've since figured out how.
> > 
> > See savegame kenn3.sav.gz in incoming.  Join game as kenn.  Keep the message
> > window open.  In the Jericho city, disable the CMA (otherwise the client 
> > will
> > crash with a CMA error too soon).  Hold the Enter key down (for Turn Done) 
> > until
> > around 1931.
> > 
> > Then, the civserver should crash, and the client continously tries to 
> > connect,
> > and prints "Lost connection to server" lines in the text area of the 
> > client, and
> > pops up many "Connection to Freeciv Server" dialog boxes.  The only way I've
> > found to stop it is to press Ctrl-Alt-Backspace within the first 30 or so of
> > them.. otherwise they lock up the whole system.  If debugging is on, the 
> > client
> > spits out the following lines:
> > 
> > 2: lost connection to server
> > 2: error in select() return=-1 errno=9 (Bad file descriptor)
> > 2: lost connection to server
> > 2: error in select() return=-1 errno=9 (Bad file descriptor)
> > 2: lost connection to server
> > 2: error in select() return=-1 errno=9 (Bad file descriptor)
> > 2: lost connection to server
> > 2: error in select() return=-1 errno=9 (Bad file descriptor)
> > 
> > I'm using cvs from May 17, Red Hat 7.2, Gnome+Ximian.
> 
> I can reproduce the server crash, but not the client loop.  However, I 
> have a slight hunch that the attached patch might fix it - test it out 
> if you want.
> 
> jason
> ----
> 

> Index: client/clinet.c
> ===================================================================
> RCS file: /home/freeciv/CVS/freeciv/client/clinet.c,v
> retrieving revision 1.69
> diff -u -r1.69 clinet.c
> --- client/clinet.c   2002/04/09 14:10:09     1.69
> +++ client/clinet.c   2002/05/20 09:34:04
> @@ -381,6 +381,7 @@
>        }
>      } else {
>        close_socket_callback(&aconnection);
> +      break;
>      }
>    }
>