[Freeciv-Dev] Re: Introducing a new define for IgTer units (PR#1359)

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Thu, 4 Apr 2002, Raahul Kumar wrote:

> > > > ai/advmilitary.c, line 462 -- if (unit_type_flag(i, F_IGTER) && !def) 
> > > > cur
> > 
> > > > *= 3;
> > > 
> > > This one I'm still unsure of. This cur doesn't seem to be just move_rate.
> 
> I would like your opinion on this line. 

sorry about the delay ;)

of course you should change it, see above:

453   if (def) cur *= 3;
454   else cur *= get_unit_type(i)->move_rate;

So it gets multiplied by move_rate and IGTER is at least 3 times faster => 
3 times better.

> > > > ai/advmilitary.c, line 795 -- if (unit_flag(pdef, F_IGTER)) dist *= 3;
> > > 
> > > Dist is not always move_rate either. I've yet to untangle exactly what 
> > > dist
> > is.
> 
> And this.

Same here:

794       if (dist > m) {
795         dist *= unit_type(pdef)->move_rate;
796         if (unit_flag(pdef, F_IGTER)) dist *= 3;
797       }

Be bold, my man!


> > ai/aiunit.c, line 1219 -- if (unit_flag(punit, F_IGTER)) d_val /= 1.5;
> 
> A comment here too.

Here I haven't got a clue.  I would expect /= 3 here.  But this you 
shouldn't worry too much about, this bodyguard code is broken and I expect 
Per will fix it soon ;)

G.