[Freeciv-Dev] Re: Introducing a new define for IgTer units (PR#1359)

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

The idea of the patch is very right.  The implementation is not that good 
and terribly far from being full (see 1 and 2 below)

On Tue, 2 Apr 2002, Raahul Kumar wrote:

> Just read the patch. New #define, introducing IGTER_MOVE_BONUS. Replacing a 
> few
> misplaced 3's and SINGLE_MOVE's with the correct constant.

1. by definition of IGTER units 
IGTER_MOVE_BONUS = SINGLE_MOVE / MOVE_COST_ROAD

2. Only three differences are fixed.
A simple search gives far more hits:

ai/advmilitary.c, line 203 -- else if (unit_flag(punit, F_IGTER))
ai/advmilitary.c, line 462 -- if (unit_type_flag(i, F_IGTER) && !def) cur 
*= 3;
ai/advmilitary.c, line 597 -- q = (acity ? 1 : unit_types[n].move_rate * 
(unit_type_flag(n, F_IGTER) ? 3 : 1));
ai/advmilitary.c, line 598 -- if (unit_type_flag(i, F_IGTER)) m *= 
SINGLE_MOVE; /* not quite right */
ai/advmilitary.c, line 731 -- if (unit_type_flag(v, F_IGTER)) m *= 3; /* 
not quite right */
ai/advmilitary.c, line 795 -- if (unit_flag(pdef, F_IGTER)) dist *= 3;
ai/advmilitary.c, line 800 -- if (unit_type_flag(v, F_IGTER)) m *= 3; /* 
not quite right */
ai/aiunit.c, line 191 -- if (unit_flag(punit, F_IGTER)) {
ai/aiunit.c, line 1219 -- if (unit_flag(punit, F_IGTER)) d_val /= 1.5;
ai/aiunit.c, line 1600 -- if (unit_flag(punit, F_IGTER)) m *= SINGLE_MOVE;
ai/aiunit.c, line 1789 -- if (unit_flag(aunit, F_IGTER)) n *= 3;