[Freeciv-Dev] Re: [RFC][Patch] Inline

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Mar 21, 2002 at 03:12:54AM -0800, Raahul Kumar wrote:
> > <dream mode on>
> > There is an automatic patch tester. You give this bot a tree and a
> > list of patches. It will apply the patch, configure and build the code
> > (using options you specify). It will then run N autogames based on a
> > rc-template. It will measure the performance. This will be done for
> > every patch and the stock tree. Extra points for comparing the
> > savegames to the stock version. Extra points for measuring average and
> > variance. More extra points for feeding the results through
> > gnuplot. Extra points for fetching the stock tree from the CVS
> > repository.
> > 
> 
> I'll try and do some of this manually. A bit more detail on what you used 
> would
> be good to have. For example
> 
> 1.) rc-template

Template:
 set aifill 7
 set endyear 100 # should be removed but I didn't want to wait this long
 hard
 create Caesar

test script should add:
 set timeout -1
 start
and if requested:
 set randseed 4321
 set seed 1234
 set saveturns 1

> 2.) gcc version

3.0.3

> 3.) options for gnuplot

Doesn't need any.

> 4.) CVS version

The one from yesterday.

> 5.) kernel version is irrelevant correct?

Yes.

6.) Compile flags. The easiest solution would IMHO be if the patch
creates a file freeciv/make_options which the script passed to
make. Since these can be a lot:
 - -O2 vs -O3
 - -DUSE_INLINE or not
 - -fomit-frame-pointer or not
 - -DNDEBUG or not

7.) Enable profiling. Passed -pg to gcc and runs gprof later. Archive
the result.

> > Results:
> >  stock: 62.15s
> >  with this patch and no inlining: 80.97s (difference because of
> >  converting map_inx, dirstep,.. to functions)
> >  with this patch and inlining: 40.46s
> >  with this patch and inlining and NDEBUG: 36.83s
> >  with this patch and inlining and -O3: 39.48s
> > 
> 
> I seem to spot a missing
> 
> with this patch and inlining and -O3 and NDEBUG:
> 
> It would also be nice to have results for stock with -03 to compare with
> patch and -03.

I don't have these numbers.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
    1) Customers cause problems.
    2) Marketing is trying to create more customers.
  Therefore:
    3) Marketing is evil.