[Freeciv-Dev] Re: [RFC] square_dxy_iterate

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Sat, Feb 23, 2002 at 04:56:45PM +0000, Gregory Berkolaiko wrote:

> > flag isn't the most explanatory of names.
> > how about willing_to_attack
> > or 
> > will_fight_if_needed
> 
> Choose one.

The choice is yours

> > situation).  how about using is_enemy_city_tile instead of map_get_city
> above?
> > (here is_enemy_city_pos(x,y) would be useful)
> 
> It is more expensive. It will only be usefull if diplomacy is
> implemented. And if diplomacy gets implemented you have to audit the
> whole code (and take the runtime hit). So no.

an extra call to pplayers_at_war is that expensive?
you are not so shy about extra calls to win_chance...

leave a comment then.

G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com