Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2002:
[Freeciv-Dev] Re: [Patch] city_option_set
Home

[Freeciv-Dev] Re: [Patch] city_option_set

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>
Cc: jdorje@xxxxxxxxxxxxxxxxxxxxx, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [Patch] city_option_set
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 22 Feb 2002 17:10:17 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Fri, Feb 22, 2002 at 03:51:38PM +0000, Gregory Berkolaiko wrote:
>  --- Jason Short <vze2zq63@xxxxxxxxxxx> wrote: > Raimar Falke wrote:
> > > Encapsulated "pcity->city_options & (1<<x)" in a new function
> > > city_option_set. Alternative names anyone?
> > 
> > city_option_is_set.  Or is_city_option_set.
> > 
> > city_option_set sounds like an action, not a query...
> 
> I support Jason 100%
> 
> at first I thought that it is an action and only Jason's email forced 
> me to look at it more closely and discover that it's a test.
> So city_option_set is a VERY misleading name.

I have already applied it as is_city_option_set.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "At the beginning of the week, we sealed ten BSD programmers
  into a computer room with a single distribution of BSD Unix.
  Upon opening the room after seven days, we found all ten programmers 
  dead, clutching each other's throats, and thirteen new flavors of BSD."


[Prev in Thread] Current Thread [Next in Thread]