[Freeciv-Dev] Re: [patch rfd] loading rulesets

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- "Per I. Mathisen" <Per.Inge.Mathisen@xxxxxxxxxxx> wrote:
> This patch is for getting access to ruleset info during pre-game, as
> discussed earlier in this thread.
> 
> It moves the loading of rulesets from start of game to before pre-game, ie
> to server initialization. I also removed the entirely unnecessary
> "feature" that allowed you to mix ruleset files from different modpacks in
> the same game. Now you just feed civserver with a modpack directory
> through the "--config DIR" option, and you cannot use "set techs FILE"
> anymore. Lastly, I killed data/classic/, since I really couldn't bother to
> code around this ancient backwards compatibility hack.
> 
> This also has three side benefits:
>  - rules out a class of possible inconsistencies stemming from mixing
> incompatible ruleset files (they are incompatible more often than not)
>  - ruleset errors are detected before you start the game, which means
> before you invite all your friends into the game...
>  - no more "set techs 3" server crashes
> 
> Also, it simplies the code a bit. Adds 69 lines and removes 809... :)
> 

Good work. There should be some sort of Freeciv award for this.
I dub you Penguin of The Week.

> Yours,
> Per
> 
> "What we anticipate seldom occurs: but what we least expect generally
> happens." -- Benjamin Disraeli
> 

> ATTACHMENT part 2 application/octet-stream name=rulesetloading1.patch.gz



__________________________________________________
Do You Yahoo!?
Yahoo! Sports - Coverage of the 2002 Olympic Games
http://sports.yahoo.com