Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2002:
[Freeciv-Dev] Re: [RFC] enum cleanup 		Home

[Freeciv-Dev] Re: [RFC] enum cleanup

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jonathan Claggett <jcc.ugm@xxxxxxxxxxxxx>
Cc: Ben Webb <ben@xxxxxxxxxxxxxxxxxxxxxx>, freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [RFC] enum cleanup
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 13 Feb 2002 19:14:04 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx 
On Wed, Feb 13, 2002 at 01:11:54PM -0500, Jonathan Claggett wrote:
> 
> >government.h has:
> >
> >enum government_flag_id {
> >  G_BUILD_VETERAN_DIPLOMAT=0,   /* and Spies (in general: all
> >F_DIPLOMAT) */
> >...
> >  G_LAST_FLAG
> >};
> >#define G_FIRST_FLAG G_BUILD_VETERAN_DIPLOMAT
> >
> >So *_FIRST is a define. I would prefer this.
> >
> 
> If *_FIRST is a define, why not do the same with *_LAST? That way it really
> would be the last. Of course, that requries a slight change in the various
> iterator for/while loops from < to <=.

Yes this would clean it up further.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 Windows: Where do you want to go today?
 Linux: Where do you want to go tomorrow?
 BSD: Are you guys coming or what?
[Prev in Thread] Current Thread [Next in Thread]