[Freeciv-Dev] Re: [RFC] enum cleanup

["Jonathan Claggett" <jcc.ugm@xxxxxxxxxxxxx>]

>government.h has:
>
>enum government_flag_id {
>  G_BUILD_VETERAN_DIPLOMAT=0,   /* and Spies (in general: all
>F_DIPLOMAT) */
>...
>  G_LAST_FLAG
>};
>#define G_FIRST_FLAG G_BUILD_VETERAN_DIPLOMAT
>
>So *_FIRST is a define. I would prefer this.
>

If *_FIRST is a define, why not do the same with *_LAST? That way it really
would be the last. Of course, that requries a slight change in the various
iterator for/while loops from < to <=.

Just asking :-)
Jonathan