[Freeciv-Dev] Re: CMA stops at assert (PR#1252)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Feb 05, 2002 at 09:17:20AM -0800, Christian Knoke wrote:
> CVS 05 FEB 2002 GTK+ Linux i386
> 
> chris@max:~> civclient -t trident
> 1: ASV: Quezon hat sich mehrfach geändert. Dies könnte an einem Fehler in   
> Freeciv liegen: Bitte informieren Sie <freeciv-dev@xxxxxxxxxxx>. Die ASV für 
> diese Stadt wird deshalb jetzt abgeschaltet.
> civclient: cma_core.c:1658: handle_city: Zusicherung »0« nicht erfüllt.
> Abgebrochen (core dumped)
>  
> (gdb) bt
> #0  0x40338861 in kill () from /lib/libc.so.6
> #1  0x40338665 in raise () from /lib/libc.so.6
> #2  0x40339c81 in abort () from /lib/libc.so.6
> #3  0x40332a52 in Letext () from /lib/libc.so.6
> #4  0x080ca7da in handle_city (pcity=0x8385580) at cma_core.c:1658
> #5  0x080ca80c in city_changed (pcity=0x8385580) at cma_core.c:1673
> #6  0x080c7b81 in execute_call (call=0x84856d0) at agents.c:185
> #7  0x080c7bde in call_handle_methods () at agents.c:218
> #8  0x080c7c79 in thaw () at agents.c:251
> #9  0x080c7e6b in agents_start_turn () at agents.c:370
> #10 0x0806c44b in handle_start_turn () at packhand.c:761
> #11 0x080607d5 in handle_packet_input (packet=0x84024b8
> "\020\201B@¨Ê;\b\020", type=93)
>     at civclient.c:406
> #12 0x0806340d in input_from_server (fid=6) at clinet.c:332
> #13 0x0808efb2 in get_net_input (data=0x0, fid=6, condition=GDK_INPUT_READ)
>     at gui_main.c:1072
> #14 0x40193934 in gdk_io_invoke () from /usr/lib/libgdk-1.2.so.0
> #15 0x401c53b0 in g_io_unix_dispatch () from /usr/lib/libglib-1.2.so.0
> #16 0x401c6c46 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
> #17 0x401c7273 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
> #18 0x401c743c in g_main_run () from /usr/lib/libglib-1.2.so.0
> #19 0x400df76c in gtk_main () from /usr/lib/libgtk-1.2.so.0
> #20 0x0808ea34 in ui_main (argc=3, argv=0xbffff604) at gui_main.c:867
> #21 0x08060491 in main (argc=3, argv=0xbffff604) at civclient.c:192
> #22 0x403277ee in __libc_start_main () from /lib/libc.so.6
> 
> Reproducible. Savegame is here:
> 
> http://www.enter.de/~c.knoke/bugs/cmabug9.sav.gz
> 
> Login as chris and press Return.

Attached patch fixes the problem for me. Problem: if we have a
traderoute with an enemy city and doesn't see the city we won't get
updates for it. Especially we don't get updates of the tile_trade
field.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Life is too short for reboots."

cmabug9_fix1.diff
Description: Text document