[Freeciv-Dev] Re: [Patch] Add BOOL_VAL around ANDs

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Feb 13, 2002 at 11:35:41AM +0100, Petr Baudis wrote:
> > As of late i've been making debugging, speed improvements and minor
> > cleanups. This goes hand in hand with perceived user desires for better
> > performance and more stability. The cleanups done recently by the
> > maintainers involve no changes in outputed code. So they add (hopefully) no
> > new bugs. Raimar's patches in particular have enabled the squashing of some
> > insidious bugs in the code.
> 
> The cleanups really don't matter for the users, but they matter a lot for the
> developers. 

> They are bringing precedents and new rules to coding style of
> freeciv, and in fact developers are forced to live with them to the
> end of their days.

Since I can't expect that people to install splint it is reasonable to
add only a very soft constrains (should use bool if you know that the
variable is either TRUE or FALSE, ...) to the coding style. From time
to time somebody makes some splint runs to catch any open mistakes.

> Thus I believe they should be discussed, and IMHO even more that
> patches which just adds some features or so; if there are bugs there, you can
> always fix them.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Windows is the one true OS. MS invented the GUI. MS invented 
   the 32 bit OS. MS is open and standard. MS loves you. We have 
   always been at war with Oceana."