[Freeciv-Dev] Re: agent assertion failed (PR#1259)

[Ben Webb <ben@xxxxxxxxxxxxxxxxxxxxxx>]

On Mon, 11 Feb 2002, Raimar Falke wrote:

> Mhhh ... I looks like the test has be to moved:
> 
>   if (packet->you_can_join) {
>     freelog(LOG_VERBOSE, "join game accept:%s", packet->message);
>     aconnection.established = 1;
>     game.conn_id = packet->conn_id;
> +   agents_game_joined();
>   } else {

        That won't work for connecting to or from old servers that don't 
support the turn, attributes, processing_packets or tile_trade 
capabilities, surely. Won't the asserts in agents_game_joined() then be 
triggered? Can't you either disable the agents code if these attributes 
aren't present, or make them mandatory capabilities (in which case the 
asserts "should" never be triggered) ?

        Ben
-- 
ben@xxxxxxxxxxxxxxxxxxxxxx           http://bellatrix.pcl.ox.ac.uk/~ben/
"640K ought to be enough for anybody."
        - Bill Gates, 1981