[Freeciv-Dev] Re: AI Cleanup V 2 Part 2

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raahul Kumar <raahul_da_man@xxxxxxxxx> wrote: 
> > 
> > 2. There is a lot of hardcoded boatspeed.  I think we should add a
> FIXME
> > comment before each.  Also the lines with /* Tired of Kaput */
> comment
> > refer to triremes IMHO -- put a FIXME comment there too (because
> > unit_flag should be used to determine if it's a trireme, not the
> speed).
> >
> 
> OK. So I should just change the code to use F_TRIREME instead of
> inserting fixmes in code, or do you want to handle it?

I just had another look at the code.  It's not straightforward...
Firstly, trireme speed is 9 not 6 but I this reduction probably
corresponds to having to take a longer route.

Secondly, we cannot use unit_flag because we might not have a boat handy.

So I think a FIXME is the easiest choice, it identifies a potential
problem but doesn't introduce any new bugs.  But if you want to risk it,
go ahead.  The correct solution should be probably based on role_unit
routines.

> > just SINGLE_MOVE.  I would recommend a new define IGTER_UNIT_SPEEDUP.
> >
> 
> Done. I'll send in V 3 with IGTER_SPEEDUP

you're quick! :)

>  
> > 4. I'm not a maintainer but I would prefer if patches were:
> >  a) localised
> >  b) thorough
> > That is, one patch with the new unit_move_turns.  
> 
> OK.
> 
> >One patch for f_s_t_k changing _all_ the one-letter variables etc.  I
> think
> that >was Petr's opinion too.
> 
> Done. 

Best,
G.


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com