[Freeciv-Dev] Re: AI Cleanup V 2 Part 2

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> wrote:
> Few comments:
> 
> 1. My warmap patch doesn't touch unit_move_turns.  In any case it's
> prospects for inclusion are pretty dim.
> 
> 2. There is a lot of hardcoded boatspeed.  I think we should add a FIXME
> comment before each.  Also the lines with /* Tired of Kaput */ comment
> refer to triremes IMHO -- put a FIXME comment there too (because
> unit_flag should be used to determine if it's a trireme, not the speed).
>

OK. So I should just change the code to use F_TRIREME instead of inserting 
fixmes in code, or do you want to handle it?
 
> 3. In
>   if (unit_flag(punit, F_IGTER)) m *= 3;
> number 3 should actually be substituted by SINGLE_MOVE/MOVE_COST_ROAD,
> not
> just SINGLE_MOVE.  I would recommend a new define IGTER_UNIT_SPEEDUP.
>

Done. I'll send in V 3 with IGTER_SPEEDUP
 
> 4. I'm not a maintainer but I would prefer if patches were:
>  a) localised
>  b) thorough
> That is, one patch with the new unit_move_turns.  

OK.

>One patch for f_s_t_k changing _all_ the one-letter variables etc.  I think
that >was Petr's opinion too.

Done. 
> 
> G.
> 
>  --- Raahul Kumar <raahul_da_man@xxxxxxxxx> wrote: 
> 
> > This is the new improved AI cleanups. It does 3 things
> > 
> > Get rid of a few more one letter variables like c,m with better names
> > like move_rate, move_time
> > 
> > Clean up more hardcoded nos relating to movement with SINGLE_MOVE etc
> > substituted, Basically, I am finishing off the changes my original
> > movement
> > patch introduced.
> > 
> > Raimar's unit move turns, which is a nice rewrite of a very ugly
> > function.
> > Inspired by me, changes suggested by GB.
> > 
> > It's a fairly simple patch, there should be no great dramas deciphering
> > it.


__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com