[Freeciv-Dev] Re: new natural names patch (PR#1127)

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- jdorje@xxxxxxxxxxxxxxxxxxxxx wrote: 
> 
> Hmm, it looks like the nation.h file didn't get diffed.  After fixing 
> it, and updating the data patch for current CVS, I get this.
> 

although i have verrrry little interest in city naming, i had abrief look
at the patch.  two complaints:
1. inconsistent comments:
> +
> +
No comment for this function \/
> +static char *search_for_city_name(int x, int y, struct city_name
> *city_names)
> +{

Two differnt styles of commenitng:

> +      /*
> +       * Use a special name if the tile has a river or there
> +       * is an available name depending on the terrain.
> +       */

and

> +      /* It's tempting to give a bonus for the contrapositive too; for
> +         instance anything not marked coastal will get a bonus if it's
> +         inland.  But this will penalize rulesets that aren't
> +         fully-formed because these bonuses may be inaccurate. Later
we
> +         may want to allow a !coastal setting to handle this. */

2. BASE_READ_CITY_NAME_LIST was deleted.  Is dim set anywhere?

>    /* dim is set in BASE_READ_CITY_NAME_LIST */
>    num_misc_city_names = dim;
> 


Best,
G.


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com