[Freeciv-Dev] Re: PATCH change_specialist

[Gregor Zeitlinger <zeitling@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, 17 Dec 2001, Raimar Falke wrote:
> Could it be that the patch does two things:
>  1) make the ai obey
>  2) make the limit configurable
> ? Or have I misread it?
yes you're correct

> You can read? From AUTHORS:
> "See the file PEOPLE for everyone else involved in the Freeciv project."

> Whats wrong with TRUE and FALSE?
I just thought, if some parts of the code will be taken to Java, it makes
it easier, since Java has no preprocessor.

> > +typedef int boolean;
> A "can" or "is" in the function name is enough to indicate a boolean
> return type.
it's more clear that way. It follows the approach to make code more
readable. Thus, boolean indicates that only true and false are allowed and
any assignment statement to a boolean variable should be that way.

> > -    secfile_lookup_int_default(file, 9, "parameters.add_to_size_limit");
> > +    secfile_lookup_int_default(file, 8, "parameters.add_to_size_limit");
> ??
I thought this is a typo, but I just remember it's the correct way for
civ1 and civ2.... sorry.

-- 
Gregor Zeitlinger      
gregor@xxxxxxxxxxxxx