[Freeciv-Dev] Re: PATCH change_specialist

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Dec 17, 2001 at 12:31:45AM +0100, Gregor Zeitlinger wrote:
> This patch generalizes the concept of a minimum size required to use
> taxmen and scientists and makes the ai obey it as well. The reason I came
> over this is that I got kicked by an ai player in a game with notradesize
> 2 and no huts....

Could it be that the patch does two things:
 1) make the ai obey
 2) make the limit configurable
? Or have I misread it?

> by the way: will the ChangLog, AUTHORS and other files ever be updated?
> Especially the latter seems to be arcane.

You can read? From AUTHORS:
"See the file PEOPLE for everyone else involved in the Freeciv project."

> diff -ruN -X ../patch/diff_ignore ../freeciv-cvs/common/shared.h 
> bugs/common/shared.h
> --- ../freeciv-cvs/common/shared.h    Sat Sep 15 23:25:12 2001
> +++ bugs/common/shared.h      Mon Dec 17 00:22:23 2001
> @@ -39,6 +39,15 @@
>  #define FALSE (0)
>  #endif
>  
> +#ifndef true
> +#define true (1)
> +#endif
> +#ifndef false
> +#define false (0)
> +#endif
> +

Whats wrong with TRUE and FALSE?

> +typedef int boolean;

A "can" or "is" in the function name is enough to indicate a boolean
return type.

> -    secfile_lookup_int_default(file, 9, "parameters.add_to_size_limit");
> +    secfile_lookup_int_default(file, 8, "parameters.add_to_size_limit");
                                        ^
??

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Tank: So what do you need? Besides a miracle.
  Neo: Guns. Lots of guns.
    -- From The Matrix