[Freeciv-Dev] Re: [PATCH] Improvement effect definitions (PR#1104)

[Ben Webb <ben@xxxxxxxxxxxxxxxxxxxxxx>]

On Mon, 10 Dec 2001 jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:

> Ben Webb wrote:
> 
> >     The attached patch is the first part of the generalised 
> > improvements code from FreecivAC. It defines a number of structures and 
> > types in common/improvement.h used to keep track of any effects conferred 
> > by city improvements, and adds code to the relevant startup and shutdown 
> > routines to initialise and free these effect lists. This in itself doesn't 
> > really "do" anything, but shouldn't break any existing code, and is 
> > required for the actual implementation of these effects (to follow in 
> > later patches).
> > 
> > Testing would be appreciated...
> 
> 
> civclient: climisc.c:1042: renumber_island_impr_effect: Assertion 
> `pplayer->island_improv' failed.

        The attached patch _should_ fix the three bugs you've come 
across, which would all appear to be problems with initialisation of 
various structures clientside. Let me know if the problems continue with 
this patch applied (it goes on top of effect-init.patch).

        Ben
-- 
ben@xxxxxxxxxxxxxxxxxxxxxx           http://bellatrix.pcl.ox.ac.uk/~ben/
"And you'll never gain weight from a doughnut hole"

effect-init-fix.patch
Description: Text document